Skip to content

Demo signal: meters sit in the green target band, peaks never red - #1230

Merged
Skeyelab merged 1 commit into
mainfrom
fix/demo-signal-green
Nov 15, 2026
Merged

Skeyelab merged 1 commit into
mainfrom
fix/demo-signal-green

Conversation

@Skeyelab

Copy link
Copy Markdown
Member

Eric (2026-11-15): the Demo signal ran most peak bars into yellow and red, which reads as clipping in screenshots and the Facebook Page walkthrough clip. Make it look like a well-set show.

  • New DemoSignalLevel.peak(channel:of:phase:) in ShowRecorderKit: peak 0.20 to 0.30 (average about -19 to -15 dBFS, mostly in the target band; peaks about -10 dBFS, never red). The last channel stays silent.
  • DemoAudioDevice uses it. Debug and TestFlight builds only (Demo signal availability unchanged).

Tests: DemoSignalLevelTests failed first (no DemoSignalLevel). My first level (0.27 ± 0.05) then failed "no hot averages", so it's 0.25 ± 0.05. Full ./scripts/verify.sh passed. Checked by tests and builds only.

Assisted-by: Claude Code:claude-opus-5-5

@Skeyelab
Skeyelab enabled auto-merge (squash) November 15, 2026 05:55
@codecov

codecov Bot commented Nov 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
App/DemoAudioDevice.swift 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Skeyelab
Skeyelab merged commit bbacbf8 into main Nov 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant