Repository navigation
Demo signal: meters sit in the green target band, peaks never red - #1230
Merged
Merged
Conversation
Assisted-by: Claude Code:claude-opus-5-5
Skeyelab
enabled auto-merge (squash)
November 15, 2026 05:55
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eric (2026-11-15): the Demo signal ran most peak bars into yellow and red, which reads as clipping in screenshots and the Facebook Page walkthrough clip. Make it look like a well-set show.
DemoSignalLevel.peak(channel:of:phase:)in ShowRecorderKit: peak 0.20 to 0.30 (average about -19 to -15 dBFS, mostly in the target band; peaks about -10 dBFS, never red). The last channel stays silent.DemoAudioDeviceuses it. Debug and TestFlight builds only (Demo signal availability unchanged).Tests:
DemoSignalLevelTestsfailed first (noDemoSignalLevel). My first level (0.27 ± 0.05) then failed "no hot averages", so it's 0.25 ± 0.05. Full./scripts/verify.shpassed. Checked by tests and builds only.Assisted-by: Claude Code:claude-opus-5-5